-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linalg.conj.conjugated] Rearrange to match P3050R3 #7506
base: main
Are you sure you want to change the base?
Conversation
This was the wording requested by LWG and approved in P3050R3, but I mistakenly put P3050R2 in the straw polls.
@mhoemmen another fix for an incorrect straw poll |
whose type is \tcode{remove_cvref_t<ElementType>} | ||
with overload resolution performed in a context that includes the declaration | ||
\tcode{template<class T> conj(const T\&) = delete;}; and otherwise, | ||
\tcode{template<class U> conj(const U\&) = delete;}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame we're losing the penultimate "and", though, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind if you put the penultimate "and" back in : - ) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwakely Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, thinking about it, I don't mind the lack of a penultimate "and" here. This is an OR list (disjunction), not an AND list (conjunction).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared this against P3050R3; it looks good! Thanks! : - )
This was the wording requested by LWG and approved in P3050R3, but I mistakenly put P3050R2 in the straw polls.